Open
Conversation
Owner
|
UnicodeBasic is now using modules, so this PR should be updated so it can be reviewed. Thanks! |
Owner
|
Please don't force push, that makes reviewing much more complicated. |
Author
|
Sorry. |
fgdorais
reviewed
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes every Lean file in this package a module, so that downstream users can also be modules. (They don't have to be—non-modules can depend on modules.)
I made everything public by default as the reference recommends when migrating existing code, so there should be few breaking changes, although it's impossible to say who was
unfolding something they shouldn't have.This won't build unless the corresponding PR to UnicodeBasic is merged.